Browse Source

Merge pull request #4780 from mwei0210/master

check provided size to check whether to export
Adam Cozzette 7 years ago
parent
commit
e3ea413ab0
1 changed files with 2 additions and 1 deletions
  1. 2 1
      src/google/protobuf/compiler/js/js_generator.cc

+ 2 - 1
src/google/protobuf/compiler/js/js_generator.cc

@@ -3477,7 +3477,8 @@ void Generator::GenerateFile(const GeneratorOptions& options,
     GenerateExtension(options, printer, *it);
   }
 
-  if (options.import_style == GeneratorOptions::kImportCommonJs) {
+  // if provided is empty, do not export anything
+  if (options.import_style == GeneratorOptions::kImportCommonJs && !provided.empty()) {
     printer->Print("goog.object.extend(exports, $package$);\n",
                    "package", GetFilePath(options, file));
   }