Sfoglia il codice sorgente

address a few TODOs

Jan Tattermusch 5 anni fa
parent
commit
e14a5c8fe6

+ 8 - 1
csharp/src/Google.Protobuf.Test/MessageParsingHelpers.cs

@@ -121,7 +121,14 @@ namespace Google.Protobuf
             message.WriteTo(singleSpan);
             Assert.AreEqual(bytes, singleSpan.ToArray());
 
-            // TODO: also test different chunk sizes for IBufferWriter
+            // test for different IBufferWriter.GetSpan() segment sizes
+            for (int blockSize = 1; blockSize < 256; blockSize *= 2)
+            {
+                var segmentedBufferWriter = new ArrayBufferWriter<byte>();
+                segmentedBufferWriter.MaxGrowBy = blockSize;
+                message.WriteTo(segmentedBufferWriter);
+                Assert.AreEqual(bytes, bufferWriter.WrittenSpan.ToArray());
+            }
         }
     }
 }

+ 0 - 2
csharp/src/Google.Protobuf/MessageExtensions.cs

@@ -160,8 +160,6 @@ namespace Google.Protobuf
             WriteContext.Initialize(output, out WriteContext ctx);
             WritingPrimitivesMessages.WriteRawMessage(ref ctx, message);
             ctx.Flush();
-
-            // TODO: handling errors when IBufferWriter is used?
         }
 
         /// <summary>