浏览代码

Merge pull request #4288 from nico/nofall

Remove use of GOOGLE_FALLTHROUGH_INTENDED from protobuf.
Feng Xiao 7 年之前
父节点
当前提交
b8e47830d4
共有 2 个文件被更改,包括 1 次插入16 次删除
  1. 1 2
      src/google/protobuf/map_entry_lite.h
  2. 0 14
      src/google/protobuf/stubs/port.h

+ 1 - 2
src/google/protobuf/map_entry_lite.h

@@ -201,8 +201,7 @@ class MapEntryImpl : public Base {
             return false;
             return false;
           }
           }
           set_has_key();
           set_has_key();
-          if (!input->ExpectTag(kValueTag)) break;
-          GOOGLE_FALLTHROUGH_INTENDED;
+          break;
 
 
         case kValueTag:
         case kValueTag:
           if (!ValueTypeHandler::Read(input, mutable_value())) {
           if (!ValueTypeHandler::Read(input, mutable_value())) {

+ 0 - 14
src/google/protobuf/stubs/port.h

@@ -237,20 +237,6 @@ static const uint64 kuint64max = GOOGLE_ULONGLONG(0xFFFFFFFFFFFFFFFF);
 #define GOOGLE_SAFE_CONCURRENT_WRITES_END()
 #define GOOGLE_SAFE_CONCURRENT_WRITES_END()
 #endif
 #endif
 
 
-#if defined(__clang__) && defined(__has_cpp_attribute) \
-    && !defined(GOOGLE_PROTOBUF_OS_APPLE)
-# if defined(GOOGLE_PROTOBUF_OS_NACL) || defined(EMSCRIPTEN) || \
-     __has_cpp_attribute(clang::fallthrough)
-#  define GOOGLE_FALLTHROUGH_INTENDED [[clang::fallthrough]]
-# endif
-#elif defined(__GNUC__) && __GNUC__ > 6
-# define GOOGLE_FALLTHROUGH_INTENDED [[gnu::fallthrough]]
-#endif
-
-#ifndef GOOGLE_FALLTHROUGH_INTENDED
-# define GOOGLE_FALLTHROUGH_INTENDED
-#endif
-
 #define GOOGLE_GUARDED_BY(x)
 #define GOOGLE_GUARDED_BY(x)
 #define GOOGLE_ATTRIBUTE_COLD
 #define GOOGLE_ATTRIBUTE_COLD