Przeglądaj źródła

Merge pull request #8276 from haberman/php-warning

Added more information to "file already loaded" warning.
Joshua Haberman 4 lat temu
rodzic
commit
a97c4f4f2c
1 zmienionych plików z 4 dodań i 1 usunięć
  1. 4 1
      php/ext/google/protobuf/def.c

+ 4 - 1
php/ext/google/protobuf/def.c

@@ -916,7 +916,10 @@ static void add_descriptor(DescriptorPool *pool,
 
   if (upb_symtab_lookupfile2(pool->symtab, name.data, name.size)) {
     // Already added.
-    fprintf(stderr, "WARNING: file was already added\n");
+    zend_error(E_USER_WARNING,
+               "proto descriptor was previously loaded (included in multiple "
+               "metadata bundles?): " UPB_STRVIEW_FORMAT,
+               UPB_STRVIEW_ARGS(name));
     return;
   }