Selaa lähdekoodia

Revert "Fixed JS parsing of default map values (#6394)" (#6468)

This reverts commit dcc8ffd9c6fab3c82d3d6642a35a584aa0a3f64b.
Paul Yang 6 vuotta sitten
vanhempi
commit
a450e13a95
2 muutettua tiedostoa jossa 2 lisäystä ja 7 poistoa
  1. 2 6
      js/map.js
  2. 0 1
      src/google/protobuf/compiler/js/js_generator.cc

+ 2 - 6
js/map.js

@@ -465,15 +465,11 @@ jspb.Map.prototype.serializeBinary = function(
  *    entries with unset keys is required for maps to be backwards compatible
  *    entries with unset keys is required for maps to be backwards compatible
  *    with the repeated message representation described here: goo.gl/zuoLAC
  *    with the repeated message representation described here: goo.gl/zuoLAC
  *
  *
- * @param {V=} opt_defaultValue
- *    The default value for the type of map values.
- *
  */
  */
 jspb.Map.deserializeBinary = function(map, reader, keyReaderFn, valueReaderFn,
 jspb.Map.deserializeBinary = function(map, reader, keyReaderFn, valueReaderFn,
-                                      opt_valueReaderCallback, opt_defaultKey,
-                                      opt_defaultValue) {
+                                      opt_valueReaderCallback, opt_defaultKey) {
   var key = opt_defaultKey;
   var key = opt_defaultKey;
-  var value = opt_defaultValue;
+  var value = undefined;
 
 
   while (reader.nextField()) {
   while (reader.nextField()) {
     if (reader.isEndGroup()) {
     if (reader.isEndGroup()) {

+ 0 - 1
src/google/protobuf/compiler/js/js_generator.cc

@@ -3142,7 +3142,6 @@ void Generator::GenerateClassDeserializeBinaryField(
       printer->Print(", null");
       printer->Print(", null");
     }
     }
     printer->Print(", $defaultKey$", "defaultKey", JSFieldDefault(key_field));
     printer->Print(", $defaultKey$", "defaultKey", JSFieldDefault(key_field));
-    printer->Print(", $defaultValue$", "defaultValue", JSFieldDefault(value_field));
     printer->Print(");\n");
     printer->Print(");\n");
     printer->Print("         });\n");
     printer->Print("         });\n");
   } else {
   } else {