Browse Source

[Ruby] Fixed quadratic memory usage when appending to arrays.

The code mistakenly called realloc() instead of resize() on every
array append, causing quadratic memory usage.
Joshua Haberman 4 years ago
parent
commit
88243e45fc
1 changed files with 1 additions and 2 deletions
  1. 1 2
      ruby/ext/google/protobuf_c/ruby-upb.c

+ 1 - 2
ruby/ext/google/protobuf_c/ruby-upb.c

@@ -6663,10 +6663,9 @@ void upb_array_set(upb_array *arr, size_t i, upb_msgval val) {
 }
 }
 
 
 bool upb_array_append(upb_array *arr, upb_msgval val, upb_arena *arena) {
 bool upb_array_append(upb_array *arr, upb_msgval val, upb_arena *arena) {
-  if (!_upb_array_realloc(arr, arr->len + 1, arena)) {
+  if (!upb_array_resize(arr, arr->len + 1, arena)) {
     return false;
     return false;
   }
   }
-  arr->len++;
   upb_array_set(arr, arr->len - 1, val);
   upb_array_set(arr, arr->len - 1, val);
   return true;
   return true;
 }
 }