Browse Source

Deduplicate string suffix predicates

Yuriy Chernyshov 4 years ago
parent
commit
87f1d9e2f6
1 changed files with 1 additions and 5 deletions
  1. 1 5
      src/google/protobuf/compiler/python/python_generator.cc

+ 1 - 5
src/google/protobuf/compiler/python/python_generator.cc

@@ -69,16 +69,12 @@ namespace python {
 
 namespace {
 
-bool StrEndsWith(StringPiece sp, StringPiece x) {
-  return sp.size() >= x.size() && sp.substr(sp.size() - x.size()) == x;
-}
-
 // Returns a copy of |filename| with any trailing ".protodevel" or ".proto
 // suffix stripped.
 // TODO(robinson): Unify with copy in compiler/cpp/internal/helpers.cc.
 std::string StripProto(const std::string& filename) {
   const char* suffix =
-      StrEndsWith(filename, ".protodevel") ? ".protodevel" : ".proto";
+      HasSuffixString(filename, ".protodevel") ? ".protodevel" : ".proto";
   return StripSuffixString(filename, suffix);
 }