Browse Source

Fix php tests

Bo Yang 7 years ago
parent
commit
8758cc1606
3 changed files with 4 additions and 0 deletions
  1. 1 0
      php/ext/google/protobuf/message.c
  2. 2 0
      php/tests/compatibility_test.sh
  3. 1 0
      php/tests/test_util.php

+ 1 - 0
php/ext/google/protobuf/message.c

@@ -283,6 +283,7 @@ void build_class_from_descriptor(
 // -----------------------------------------------------------------------------
 
 void Message_construct(zval* msg, zval* array_wrapper) {
+  TSRMLS_FETCH();
   zend_class_entry* ce = Z_OBJCE_P(msg);
   MessageHeader* intern = NULL;
   if (EXPECTED(class_added(ce))) {

+ 2 - 0
php/tests/compatibility_test.sh

@@ -122,6 +122,8 @@ composer install
 tests=( array_test.php encode_decode_test.php generated_class_test.php map_field_test.php well_known_test.php )
 sed -i.bak '/php_implementation_test.php/d' phpunit.xml
 sed -i.bak '/generated_phpdoc_test.php/d' phpunit.xml
+sed -i.bak 's/generated_phpdoc_test.php//g' tests/test.sh
+sed -i.bak '/memory_leak_test.php/d' tests/test.sh
 for t in "${tests[@]}"
 do
   remove_error_test tests/$t

+ 1 - 0
php/tests/test_util.php

@@ -241,6 +241,7 @@ class TestUtil
         if (PHP_INT_SIZE == 4) {
             assert('-43' === $m->getRepeatedInt64()[0]);
             assert('43'  === $m->getRepeatedUint64()[0]);
+            var_dump($m->getRepeatedSint64()[0]);
             assert('-45' === $m->getRepeatedSint64()[0]);
             assert('47'  === $m->getRepeatedFixed64()[0]);
             assert('-47' === $m->getRepeatedSfixed64()[0]);