Przeglądaj źródła

Merge pull request #3327 from htuch/fix-3322

Use consistent hash across NDEBUG/!NDEBUG builds.
Feng Xiao 8 lat temu
rodzic
commit
6aa4b20fc7
1 zmienionych plików z 0 dodań i 7 usunięć
  1. 0 7
      src/google/protobuf/map.h

+ 0 - 7
src/google/protobuf/map.h

@@ -862,14 +862,7 @@ class Map {
     size_type BucketNumber(const Key& k) const {
       // We inherit from hasher, so one-arg operator() provides a hash function.
       size_type h = (*const_cast<InnerMap*>(this))(k);
-      // To help prevent people from making assumptions about the hash function,
-      // we use the seed differently depending on NDEBUG.  The default hash
-      // function, the seeding, etc., are all likely to change in the future.
-#ifndef NDEBUG
-      return (h * (seed_ | 1)) & (num_buckets_ - 1);
-#else
       return (h + seed_) & (num_buckets_ - 1);
-#endif
     }
 
     bool IsMatch(const Key& k0, const Key& k1) const {