Browse Source

Fix 32/64-bit confusion on Solaris 10 x86. Patch from Oliver Jowett.

kenton@google.com 15 years ago
parent
commit
45258ff4e2
3 changed files with 12 additions and 2 deletions
  1. 1 0
      CONTRIBUTORS.txt
  2. 4 2
      configure.ac
  3. 7 0
      m4/acx_check_suncc.m4

+ 1 - 0
CONTRIBUTORS.txt

@@ -77,6 +77,7 @@ Patch contributors:
     * HPUX support.
     * HPUX support.
   Oliver Jowett <oliver.jowett@gmail.com>
   Oliver Jowett <oliver.jowett@gmail.com>
     * Detect whether zlib is new enough in configure script.
     * Detect whether zlib is new enough in configure script.
+    * Fixes for Solaris 10 32/64-bit confusion.
   Evan Jones <evanj@mit.edu>
   Evan Jones <evanj@mit.edu>
     * Optimize Java serialization code when writing a small message to a stream.
     * Optimize Java serialization code when writing a small message to a stream.
   Michael Kucharski <m.kucharski@gmail.com>
   Michael Kucharski <m.kucharski@gmail.com>

+ 4 - 2
configure.ac

@@ -138,8 +138,10 @@ AM_CONDITIONAL([USE_EXTERNAL_PROTOC], [test "$with_protoc" != "no"])
 ACX_PTHREAD
 ACX_PTHREAD
 AC_CXX_STL_HASH
 AC_CXX_STL_HASH
 
 
-# HACK:  Make gtest's configure script pick up our copy of CXXFLAGS, since the
-#   flags added by ACX_CHECK_SUNCC must be used when compiling gtest too.
+# HACK:  Make gtest's configure script pick up our copy of CFLAGS and CXXFLAGS,
+#   since the flags added by ACX_CHECK_SUNCC must be used when compiling gtest
+#   too.
+export CFLAGS
 export CXXFLAGS
 export CXXFLAGS
 AC_CONFIG_SUBDIRS([gtest])
 AC_CONFIG_SUBDIRS([gtest])
 
 

+ 7 - 0
m4/acx_check_suncc.m4

@@ -54,12 +54,19 @@ AC_DEFUN([ACX_CHECK_SUNCC],[
 
 
           dnl This should just be set in CPPFLAGS and in LDFLAGS, but libtool
           dnl This should just be set in CPPFLAGS and in LDFLAGS, but libtool
           dnl does the wrong thing if you don't put it into CXXFLAGS. sigh.
           dnl does the wrong thing if you don't put it into CXXFLAGS. sigh.
+          dnl (It also needs it in CFLAGS, or it does a different wrong thing!)
           AS_IF([test "x${ac_cv_env_CXXFLAGS_set}" = "x"],[
           AS_IF([test "x${ac_cv_env_CXXFLAGS_set}" = "x"],[
             CXXFLAGS="${CXXFLAGS} -m64"
             CXXFLAGS="${CXXFLAGS} -m64"
             ac_cv_env_CXXFLAGS_set=set
             ac_cv_env_CXXFLAGS_set=set
             ac_cv_env_CXXFLAGS_value='-m64'
             ac_cv_env_CXXFLAGS_value='-m64'
           ])
           ])
 
 
+          AS_IF([test "x${ac_cv_env_CFLAGS_set}" = "x"],[
+            CFLAGS="${CFLAGS} -m64"
+            ac_cv_env_CFLAGS_set=set
+            ac_cv_env_CFLAGS_value='-m64'
+          ])
+
           AS_IF([test "$target_cpu" = "sparc" -a "x$SUNCC" = "xyes" ],[
           AS_IF([test "$target_cpu" = "sparc" -a "x$SUNCC" = "xyes" ],[
             CXXFLAGS="-xmemalign=8s ${CXXFLAGS}"
             CXXFLAGS="-xmemalign=8s ${CXXFLAGS}"
           ])
           ])