浏览代码

Review feedback.

- Better error message for unknown messageType.
- Remove unneeded if.
Thomas Van Lenten 8 年之前
父节点
当前提交
3caf9fd00a
共有 1 个文件被更改,包括 6 次插入8 次删除
  1. 6 8
      conformance/conformance_objc.m

+ 6 - 8
conformance/conformance_objc.m

@@ -78,15 +78,13 @@ static ConformanceResponse *DoTest(ConformanceRequest *request) {
       } else if ([request.messageType isEqual:@"protobuf_test_messages.proto2.TestAllTypesProto2"]) {
       } else if ([request.messageType isEqual:@"protobuf_test_messages.proto2.TestAllTypesProto2"]) {
         msgClass = [TestAllTypesProto2 class];
         msgClass = [TestAllTypesProto2 class];
       } else {
       } else {
-        Die(@"Protobuf request doesn't have specific payload type");
+        Die(@"Protobuf request had an unknown message_type: %@", request.messageType);
       }
       }
-      if (msgClass) {
-        NSError *error = nil;
-        testMessage = [msgClass parseFromData:request.protobufPayload error:&error];
-        if (!testMessage) {
-          response.parseError =
-              [NSString stringWithFormat:@"Parse error: %@", error];
-        }
+      NSError *error = nil;
+      testMessage = [msgClass parseFromData:request.protobufPayload error:&error];
+      if (!testMessage) {
+        response.parseError =
+            [NSString stringWithFormat:@"Parse error: %@", error];
       }
       }
       break;
       break;
     }
     }