浏览代码

Add binary conformance test case for bytes field (#6428)

* Add binary conformance test case for bytes field

* Add failed conformance test to php's failure list
Paul Yang 6 年之前
父节点
当前提交
29e4fadbfb
共有 2 个文件被更改,包括 7 次插入1 次删除
  1. 5 1
      conformance/binary_json_conformance_suite.cc
  2. 2 0
      conformance/failure_list_php_c.txt

+ 5 - 1
conformance/binary_json_conformance_suite.cc

@@ -799,11 +799,15 @@ void BinaryAndJsonConformanceSuite::RunSuiteImpl() {
     {delim("\xF0\x9F\x98\x81"), "\"\xF0\x9F\x98\x81\""},  // emoji: 😁
     {delim(""), "\"\""},
   });
+  TestValidDataForType(FieldDescriptor::TYPE_BYTES, {
+    {delim("\x01\x02"), "\"\x01\x02\""},
+    {delim("\xfb"), "\"\xfb\""},
+    {delim(""), "\"\""},
+  });
 
   // TODO(haberman):
   // TestValidDataForType(FieldDescriptor::TYPE_GROUP
   // TestValidDataForType(FieldDescriptor::TYPE_MESSAGE
-  // TestValidDataForType(FieldDescriptor::TYPE_BYTES
   // TestValidDataForType(FieldDescriptor::TYPE_ENUM
 
   RunValidJsonTest("HelloWorld", REQUIRED,

+ 2 - 0
conformance/failure_list_php_c.txt

@@ -44,3 +44,5 @@ Required.Proto3.ProtobufInput.ValidDataRepeated.FLOAT.JsonOutput
 Required.Proto3.JsonInput.RejectTopLevelNull
 Required.Proto3.ProtobufInput.ValidDataRepeated.STRING.JsonOutput
 Required.Proto3.ProtobufInput.ValidDataRepeated.STRING.ProtobufOutput
+Required.Proto3.ProtobufInput.ValidDataRepeated.BYTES.JsonOutput
+Required.Proto3.ProtobufInput.ValidDataRepeated.BYTES.ProtobufOutput