Bladeren bron

Updates for PR comments.

Josh Haberman 9 jaren geleden
bovenliggende
commit
1ce5bd8e84
2 gewijzigde bestanden met toevoegingen van 6 en 5 verwijderingen
  1. 2 1
      benchmarks/Makefile.am
  2. 4 4
      benchmarks/benchmarks.proto

+ 2 - 1
benchmarks/Makefile.am

@@ -27,8 +27,9 @@ nodist_generate_datasets_SOURCES =                             \
   $(benchmarks_protoc_outputs)                                 \
   $(benchmarks_protoc_outputs_proto2)
 
-# Explicit deps beacuse BUILT_SOURCES are only done before a "make all/check"
+# Explicit deps because BUILT_SOURCES are only done before a "make all/check"
 # so a direct "make test_cpp" could fail if parallel enough.
+# See: https://www.gnu.org/software/automake/manual/html_node/Built-Sources-Example.html#Recording-Dependencies-manually
 generate_datasets-generate_datasets.$(OBJEXT): benchmarks.pb.h google_message1.h google_message2.h
 
 $(benchmarks_protoc_outputs): protoc_middleman

+ 4 - 4
benchmarks/benchmarks.proto

@@ -68,16 +68,16 @@ message Metric {
   // A unique ID for these results.  Used for de-duping.
   string guid = 1;
 
-  // The tags specify exactly what benchmark was run against the dataset.
+  // The labels specify exactly what benchmark was run against the dataset.
   // The specific benchmark suite can decide what these mean, but here are
-  // some common tags that have a predefined meaning:
+  // some common labels that have a predefined meaning:
   //
   //   - "dataset": for tests that pertain to a specific dataset.
   //
   // For example:
   //
   //   # Tests parsing from binary proto string using arenas.
-  //   tags={
+  //   labels={
   //     dataset: "testalltypes",
   //     op: "parse",
   //     format: "binaryproto",
@@ -86,7 +86,7 @@ message Metric {
   //   }
   //
   //   # Tests serializing to JSON string.
-  //   tags={
+  //   labels={
   //     dataset: "testalltypes",
   //     op: "serialize",
   //     format: "json",