Yilun Chong 7 years ago
parent
commit
1bec76f04c
1 changed files with 6 additions and 1 deletions
  1. 6 1
      js/binary/reader_test.js

+ 6 - 1
js/binary/reader_test.js

@@ -679,8 +679,13 @@ describe('binaryReaderTest', function() {
     writer.writeInt32(5, sentinel);
     writer.writeInt32(5, sentinel);
     var dummyMessage = /** @type {!jspb.BinaryMessage} */({});
     var dummyMessage = /** @type {!jspb.BinaryMessage} */({});
     writer.writeGroup(5, dummyMessage, function() {
     writer.writeGroup(5, dummyMessage, function() {
-      writer.writeInt64(42, 42);
+      // Previously the skipGroup implementation was wrong, which only consume 
+      // the decoder by nextField. This case is for making the previous 
+      // implementation failed in skipGroup by an early end group tag.
       writer.writeInt64(44, 44);
       writer.writeInt64(44, 44);
+      writer.writeInt64(42, 42);
+      // This is for making the previous implementation failed by an invalid 
+      // varint.
       writer.writeBytes(43, [255, 255, 255, 255, 255, 255, 255, 255, 255, 255]);
       writer.writeBytes(43, [255, 255, 255, 255, 255, 255, 255, 255, 255, 255]);
       writer.writeGroup(6, dummyMessage, function() {
       writer.writeGroup(6, dummyMessage, function() {
         writer.writeInt64(84, 42);
         writer.writeInt64(84, 42);