Merge pull request #727 from ctiller/deprecate-c++

s/CreateChannel/CreateChannelDeprecated

examples/pubsub/publisher_test.cc

@@ -110,7 +110,8 @@ class PublisherTest : public ::testing::Test {
     builder.RegisterService(&service_);
     server_ = builder.BuildAndStart();
 
-    channel_ = CreateChannel(server_address_.str(), ChannelArguments());
+    channel_ =
+        CreateChannelDeprecated(server_address_.str(), ChannelArguments());
 
     publisher_.reset(new grpc::examples::pubsub::Publisher(channel_));
   }

examples/pubsub/subscriber_test.cc

@@ -109,7 +109,8 @@ class SubscriberTest : public ::testing::Test {
     builder.RegisterService(&service_);
     server_ = builder.BuildAndStart();
 
-    channel_ = CreateChannel(server_address_.str(), ChannelArguments());
+    channel_ =
+        CreateChannelDeprecated(server_address_.str(), ChannelArguments());
 
     subscriber_.reset(new grpc::examples::pubsub::Subscriber(channel_));
   }

include/grpc++/create_channel.h

@@ -43,8 +43,10 @@ namespace grpc {
 class ChannelArguments;
 class ChannelInterface;
 
-std::shared_ptr<ChannelInterface> CreateChannel(const grpc::string& target,
-                                                const ChannelArguments& args);
+// Deprecation warning: This function will soon be deleted
+// (See pull request #711)
+std::shared_ptr<ChannelInterface> CreateChannelDeprecated(
+    const grpc::string& target, const ChannelArguments& args);
 
 // If creds does not hold an object or is invalid, a lame channel is returned.
 std::shared_ptr<ChannelInterface> CreateChannel(

src/cpp/client/create_channel.cc

@@ -40,8 +40,8 @@
 namespace grpc {
 class ChannelArguments;
 
-std::shared_ptr<ChannelInterface> CreateChannel(const grpc::string &target,
-                                                const ChannelArguments &args) {
+std::shared_ptr<ChannelInterface> CreateChannelDeprecated(
+    const grpc::string &target, const ChannelArguments &args) {
   return std::shared_ptr<ChannelInterface>(new Channel(target, args));
 }
 

test/cpp/end2end/async_end2end_test.cc

@@ -105,7 +105,7 @@ class AsyncEnd2endTest : public ::testing::Test {
 
   void ResetStub() {
     std::shared_ptr<ChannelInterface> channel =
-        CreateChannel(server_address_.str(), ChannelArguments());
+        CreateChannelDeprecated(server_address_.str(), ChannelArguments());
     stub_ = std::move(grpc::cpp::test::util::TestService::NewStub(channel));
   }
 

test/cpp/end2end/end2end_test.cc

@@ -161,7 +161,7 @@ class End2endTest : public ::testing::Test {
 
   void ResetStub() {
     std::shared_ptr<ChannelInterface> channel =
-        CreateChannel(server_address_.str(), ChannelArguments());
+        CreateChannelDeprecated(server_address_.str(), ChannelArguments());
     stub_ = std::move(grpc::cpp::test::util::TestService::NewStub(channel));
   }
 
@@ -372,7 +372,7 @@ TEST_F(End2endTest, BidiStream) {
 // The two stubs are created on the same channel.
 TEST_F(End2endTest, DiffPackageServices) {
   std::shared_ptr<ChannelInterface> channel =
-      CreateChannel(server_address_.str(), ChannelArguments());
+      CreateChannelDeprecated(server_address_.str(), ChannelArguments());
 
   EchoRequest request;
   EchoResponse response;

test/cpp/util/create_test_channel.cc

@@ -79,7 +79,7 @@ std::shared_ptr<ChannelInterface> CreateTestChannel(
     }
     return CreateChannel(connect_to, channel_creds, channel_args);
   } else {
-    return CreateChannel(server, channel_args);
+    return CreateChannelDeprecated(server, channel_args);
   }
 }