瀏覽代碼

Added the client and server configurations to the bench results proto.

The added configurations also include the host of both parties. This
is useful for reporting.
David Garcia Quintas 10 年之前
父節點
當前提交
6ba29ba3fb
共有 3 個文件被更改,包括 15 次插入0 次删除
  1. 11 0
      test/cpp/qps/driver.cc
  2. 2 0
      test/cpp/qps/driver.h
  3. 2 0
      test/cpp/qps/qpstest.proto

+ 11 - 0
test/cpp/qps/driver.cc

@@ -89,6 +89,11 @@ ScenarioResult RunScenario(const ClientConfig& initial_client_config,
     return &contexts.back();
     return &contexts.back();
   };
   };
 
 
+  // To be added to the result, containing the final configuration used for
+  // client and config (incluiding host, etc.)
+  ClientConfig result_client_config;
+  ServerConfig result_server_config;
+
   // Get client, server lists
   // Get client, server lists
   auto workers = get_hosts("QPS_WORKERS");
   auto workers = get_hosts("QPS_WORKERS");
   ClientConfig client_config = initial_client_config;
   ClientConfig client_config = initial_client_config;
@@ -127,6 +132,8 @@ ScenarioResult RunScenario(const ClientConfig& initial_client_config,
     sd.stub = std::move(Worker::NewStub(
     sd.stub = std::move(Worker::NewStub(
         CreateChannel(workers[i], InsecureCredentials(), ChannelArguments())));
         CreateChannel(workers[i], InsecureCredentials(), ChannelArguments())));
     ServerArgs args;
     ServerArgs args;
+    result_server_config = server_config;
+    result_server_config.set_host(workers[i]);
     *args.mutable_setup() = server_config;
     *args.mutable_setup() = server_config;
     sd.stream = std::move(sd.stub->RunServer(alloc_context()));
     sd.stream = std::move(sd.stub->RunServer(alloc_context()));
     GPR_ASSERT(sd.stream->Write(args));
     GPR_ASSERT(sd.stream->Write(args));
@@ -156,6 +163,8 @@ ScenarioResult RunScenario(const ClientConfig& initial_client_config,
     cd.stub = std::move(Worker::NewStub(CreateChannel(
     cd.stub = std::move(Worker::NewStub(CreateChannel(
         workers[i + num_servers], InsecureCredentials(), ChannelArguments())));
         workers[i + num_servers], InsecureCredentials(), ChannelArguments())));
     ClientArgs args;
     ClientArgs args;
+    result_client_config = client_config;
+    result_client_config.set_host(workers[i + num_servers]);
     *args.mutable_setup() = client_config;
     *args.mutable_setup() = client_config;
     cd.stream = std::move(cd.stub->RunTest(alloc_context()));
     cd.stream = std::move(cd.stub->RunTest(alloc_context()));
     GPR_ASSERT(cd.stream->Write(args));
     GPR_ASSERT(cd.stream->Write(args));
@@ -197,6 +206,8 @@ ScenarioResult RunScenario(const ClientConfig& initial_client_config,
 
 
   // Finish a run
   // Finish a run
   ScenarioResult result;
   ScenarioResult result;
+  result.client_config = result_client_config;
+  result.server_config = result_server_config;
   gpr_log(GPR_INFO, "Finishing");
   gpr_log(GPR_INFO, "Finishing");
   for (auto server = servers.begin(); server != servers.end(); server++) {
   for (auto server = servers.begin(); server != servers.end(); server++) {
     GPR_ASSERT(server->stream->Write(server_mark));
     GPR_ASSERT(server->stream->Write(server_mark));

+ 2 - 0
test/cpp/qps/driver.h

@@ -49,6 +49,8 @@ struct ScenarioResult {
   Histogram latencies;
   Histogram latencies;
   std::vector<ResourceUsage> client_resources;
   std::vector<ResourceUsage> client_resources;
   std::vector<ResourceUsage> server_resources;
   std::vector<ResourceUsage> server_resources;
+  ClientConfig client_config;
+  ServerConfig server_config;
 };
 };
 
 
 ScenarioResult RunScenario(const grpc::testing::ClientConfig& client_config,
 ScenarioResult RunScenario(const grpc::testing::ClientConfig& client_config,

+ 2 - 0
test/cpp/qps/qpstest.proto

@@ -102,6 +102,7 @@ message ClientConfig {
   // only for async client:
   // only for async client:
   optional int32 async_client_threads = 7;
   optional int32 async_client_threads = 7;
   optional RpcType rpc_type = 8 [default=UNARY];
   optional RpcType rpc_type = 8 [default=UNARY];
+  optional string host = 9;
 }
 }
 
 
 // Request current stats
 // Request current stats
@@ -129,6 +130,7 @@ message ServerConfig {
   required ServerType server_type = 1;
   required ServerType server_type = 1;
   optional int32 threads = 2 [default=1];
   optional int32 threads = 2 [default=1];
   optional bool enable_ssl = 3 [default=false];
   optional bool enable_ssl = 3 [default=false];
+  optional string host = 4;
 }
 }
 
 
 message ServerArgs {
 message ServerArgs {