Revert "Revert "Refactor Channelz Service to Support Internal Build""

This reverts commit 2eafaccba6510cd501f723c8f7146d11aff23586.

include/grpcpp/impl/codegen/config_protobuf.h

@@ -66,6 +66,11 @@
 #define GRPC_CUSTOM_CODEDINPUTSTREAM ::google::protobuf::io::CodedInputStream
 #endif
 
+#ifndef GRPC_CUSTOM_UTIL_STATUS
+#include <google/protobuf/util/json_util.h>
+#define GRPC_CUSTOM_UTIL_STATUS ::google::protobuf::util::Status
+#endif
+
 namespace grpc {
 namespace protobuf {
 
@@ -83,6 +88,17 @@ typedef GRPC_CUSTOM_SERVICEDESCRIPTOR ServiceDescriptor;
 typedef GRPC_CUSTOM_SIMPLEDESCRIPTORDATABASE SimpleDescriptorDatabase;
 typedef GRPC_CUSTOM_SOURCELOCATION SourceLocation;
 
+namespace util {
+typedef GRPC_CUSTOM_UTIL_STATUS Status;
+
+inline util::Status JsonStringToMessage(const std::string& input,
+                                        Message* message) {
+  return ::google::protobuf::util::JsonStringToMessage(
+      input, message, ::google::protobuf::util::JsonParseOptions());
+}
+
+}  // namespace util
+
 namespace io {
 typedef GRPC_CUSTOM_ZEROCOPYOUTPUTSTREAM ZeroCopyOutputStream;
 typedef GRPC_CUSTOM_ZEROCOPYINPUTSTREAM ZeroCopyInputStream;

src/cpp/server/channelz/channelz_service.cc

@@ -20,9 +20,6 @@
 
 #include "src/cpp/server/channelz/channelz_service.h"
 
-#include <google/protobuf/text_format.h>
-#include <google/protobuf/util/json_util.h>
-
 #include <grpc/grpc.h>
 #include <grpc/support/alloc.h>
 
@@ -33,13 +30,14 @@ Status ChannelzService::GetTopChannels(
     channelz::v1::GetTopChannelsResponse* response) {
   char* json_str = grpc_channelz_get_top_channels(request->start_channel_id());
   if (json_str == nullptr) {
-    return Status(INTERNAL, "grpc_channelz_get_top_channels returned null");
+    return Status(StatusCode::INTERNAL,
+                  "grpc_channelz_get_top_channels returned null");
   }
-  google::protobuf::util::Status s =
-      google::protobuf::util::JsonStringToMessage(json_str, response);
+  grpc::protobuf::util::Status s =
+      grpc::protobuf::util::JsonStringToMessage(json_str, response);
   gpr_free(json_str);
-  if (s != google::protobuf::util::Status::OK) {
-    return Status(INTERNAL, s.ToString());
+  if (!s.ok()) {
+    return Status(StatusCode::INTERNAL, s.ToString());
   }
   return Status::OK;
 }
@@ -49,13 +47,14 @@ Status ChannelzService::GetServers(
     channelz::v1::GetServersResponse* response) {
   char* json_str = grpc_channelz_get_servers(request->start_server_id());
   if (json_str == nullptr) {
-    return Status(INTERNAL, "grpc_channelz_get_servers returned null");
+    return Status(StatusCode::INTERNAL,
+                  "grpc_channelz_get_servers returned null");
   }
-  google::protobuf::util::Status s =
-      google::protobuf::util::JsonStringToMessage(json_str, response);
+  grpc::protobuf::util::Status s =
+      grpc::protobuf::util::JsonStringToMessage(json_str, response);
   gpr_free(json_str);
-  if (s != google::protobuf::util::Status::OK) {
-    return Status(INTERNAL, s.ToString());
+  if (!s.ok()) {
+    return Status(StatusCode::INTERNAL, s.ToString());
   }
   return Status::OK;
 }
@@ -66,13 +65,14 @@ Status ChannelzService::GetServerSockets(
   char* json_str = grpc_channelz_get_server_sockets(request->server_id(),
                                                     request->start_socket_id());
   if (json_str == nullptr) {
-    return Status(INTERNAL, "grpc_channelz_get_server_sockets returned null");
+    return Status(StatusCode::INTERNAL,
+                  "grpc_channelz_get_server_sockets returned null");
   }
-  google::protobuf::util::Status s =
-      google::protobuf::util::JsonStringToMessage(json_str, response);
+  grpc::protobuf::util::Status s =
+      grpc::protobuf::util::JsonStringToMessage(json_str, response);
   gpr_free(json_str);
-  if (s != google::protobuf::util::Status::OK) {
-    return Status(INTERNAL, s.ToString());
+  if (!s.ok()) {
+    return Status(StatusCode::INTERNAL, s.ToString());
   }
   return Status::OK;
 }
@@ -82,13 +82,13 @@ Status ChannelzService::GetChannel(
     channelz::v1::GetChannelResponse* response) {
   char* json_str = grpc_channelz_get_channel(request->channel_id());
   if (json_str == nullptr) {
-    return Status(NOT_FOUND, "No object found for that ChannelId");
+    return Status(StatusCode::NOT_FOUND, "No object found for that ChannelId");
   }
-  google::protobuf::util::Status s =
-      google::protobuf::util::JsonStringToMessage(json_str, response);
+  grpc::protobuf::util::Status s =
+      grpc::protobuf::util::JsonStringToMessage(json_str, response);
   gpr_free(json_str);
-  if (s != google::protobuf::util::Status::OK) {
-    return Status(INTERNAL, s.ToString());
+  if (!s.ok()) {
+    return Status(StatusCode::INTERNAL, s.ToString());
   }
   return Status::OK;
 }
@@ -98,13 +98,14 @@ Status ChannelzService::GetSubchannel(
     channelz::v1::GetSubchannelResponse* response) {
   char* json_str = grpc_channelz_get_subchannel(request->subchannel_id());
   if (json_str == nullptr) {
-    return Status(NOT_FOUND, "No object found for that SubchannelId");
+    return Status(StatusCode::NOT_FOUND,
+                  "No object found for that SubchannelId");
   }
-  google::protobuf::util::Status s =
-      google::protobuf::util::JsonStringToMessage(json_str, response);
+  grpc::protobuf::util::Status s =
+      grpc::protobuf::util::JsonStringToMessage(json_str, response);
   gpr_free(json_str);
-  if (s != google::protobuf::util::Status::OK) {
-    return Status(INTERNAL, s.ToString());
+  if (!s.ok()) {
+    return Status(StatusCode::INTERNAL, s.ToString());
   }
   return Status::OK;
 }
@@ -114,13 +115,13 @@ Status ChannelzService::GetSocket(ServerContext* unused,
                                   channelz::v1::GetSocketResponse* response) {
   char* json_str = grpc_channelz_get_socket(request->socket_id());
   if (json_str == nullptr) {
-    return Status(NOT_FOUND, "No object found for that SocketId");
+    return Status(StatusCode::NOT_FOUND, "No object found for that SocketId");
   }
-  google::protobuf::util::Status s =
-      google::protobuf::util::JsonStringToMessage(json_str, response);
+  grpc::protobuf::util::Status s =
+      grpc::protobuf::util::JsonStringToMessage(json_str, response);
   gpr_free(json_str);
-  if (s != google::protobuf::util::Status::OK) {
-    return Status(INTERNAL, s.ToString());
+  if (!s.ok()) {
+    return Status(StatusCode::INTERNAL, s.ToString());
   }
   return Status::OK;
 }