Merge pull request #23894 from yashykt/removegrpcchannelping

Remove grpc_channel_ping from surface API

grpc.def

@@ -35,7 +35,6 @@ EXPORTS
     grpc_channel_watch_connectivity_state
     grpc_channel_support_connectivity_watcher
     grpc_channel_create_call
-    grpc_channel_ping
     grpc_channel_register_call
     grpc_channel_create_registered_call
     grpc_call_arena_alloc

include/grpc/grpc.h

@@ -219,11 +219,6 @@ GRPCAPI grpc_call* grpc_channel_create_call(
     grpc_completion_queue* completion_queue, grpc_slice method,
     const grpc_slice* host, gpr_timespec deadline, void* reserved);
 
-/** Ping the channels peer (load balanced channels will select one sub-channel
-    to ping); if the channel is not connected, posts a failed. */
-GRPCAPI void grpc_channel_ping(grpc_channel* channel, grpc_completion_queue* cq,
-                               void* tag, void* reserved);
-
 /** Pre-register a method/host pair on a channel.
     method and host are not owned and must remain alive while the channel is
     alive. */

src/core/lib/surface/channel.h

@@ -161,8 +161,13 @@ inline void grpc_channel_internal_unref(grpc_channel* channel) {
   grpc_channel_internal_unref(channel)
 #endif
 
-/** Return the channel's compression options. */
+// Return the channel's compression options.
 grpc_compression_options grpc_channel_compression_options(
     const grpc_channel* channel);
 
+// Ping the channels peer (load balanced channels will select one sub-channel to
+// ping); if the channel is not connected, posts a failed.
+void grpc_channel_ping(grpc_channel* channel, grpc_completion_queue* cq,
+                       void* tag, void* reserved);
+
 #endif /* GRPC_CORE_LIB_SURFACE_CHANNEL_H */

src/ruby/ext/grpc/rb_grpc_imports.generated.c

@@ -58,7 +58,6 @@ grpc_channel_num_external_connectivity_watchers_type grpc_channel_num_external_c
 grpc_channel_watch_connectivity_state_type grpc_channel_watch_connectivity_state_import;
 grpc_channel_support_connectivity_watcher_type grpc_channel_support_connectivity_watcher_import;
 grpc_channel_create_call_type grpc_channel_create_call_import;
-grpc_channel_ping_type grpc_channel_ping_import;
 grpc_channel_register_call_type grpc_channel_register_call_import;
 grpc_channel_create_registered_call_type grpc_channel_create_registered_call_import;
 grpc_call_arena_alloc_type grpc_call_arena_alloc_import;
@@ -332,7 +331,6 @@ void grpc_rb_load_imports(HMODULE library) {
   grpc_channel_watch_connectivity_state_import = (grpc_channel_watch_connectivity_state_type) GetProcAddress(library, "grpc_channel_watch_connectivity_state");
   grpc_channel_support_connectivity_watcher_import = (grpc_channel_support_connectivity_watcher_type) GetProcAddress(library, "grpc_channel_support_connectivity_watcher");
   grpc_channel_create_call_import = (grpc_channel_create_call_type) GetProcAddress(library, "grpc_channel_create_call");
-  grpc_channel_ping_import = (grpc_channel_ping_type) GetProcAddress(library, "grpc_channel_ping");
   grpc_channel_register_call_import = (grpc_channel_register_call_type) GetProcAddress(library, "grpc_channel_register_call");
   grpc_channel_create_registered_call_import = (grpc_channel_create_registered_call_type) GetProcAddress(library, "grpc_channel_create_registered_call");
   grpc_call_arena_alloc_import = (grpc_call_arena_alloc_type) GetProcAddress(library, "grpc_call_arena_alloc");

src/ruby/ext/grpc/rb_grpc_imports.generated.h

@@ -149,9 +149,6 @@ extern grpc_channel_support_connectivity_watcher_type grpc_channel_support_conne
 typedef grpc_call*(*grpc_channel_create_call_type)(grpc_channel* channel, grpc_call* parent_call, uint32_t propagation_mask, grpc_completion_queue* completion_queue, grpc_slice method, const grpc_slice* host, gpr_timespec deadline, void* reserved);
 extern grpc_channel_create_call_type grpc_channel_create_call_import;
 #define grpc_channel_create_call grpc_channel_create_call_import
-typedef void(*grpc_channel_ping_type)(grpc_channel* channel, grpc_completion_queue* cq, void* tag, void* reserved);
-extern grpc_channel_ping_type grpc_channel_ping_import;
-#define grpc_channel_ping grpc_channel_ping_import
 typedef void*(*grpc_channel_register_call_type)(grpc_channel* channel, const char* method, const char* host, void* reserved);
 extern grpc_channel_register_call_type grpc_channel_register_call_import;
 #define grpc_channel_register_call grpc_channel_register_call_import

test/core/end2end/tests/bad_ping.cc

@@ -26,6 +26,7 @@
 #include <grpc/support/time.h>
 
 #include "src/core/lib/gpr/useful.h"
+#include "src/core/lib/surface/channel.h"
 #include "test/core/end2end/cq_verifier.h"
 
 #define MAX_PING_STRIKES 2

test/core/end2end/tests/ping.cc

@@ -23,6 +23,7 @@
 #include <grpc/support/time.h>
 
 #include "src/core/lib/gpr/useful.h"
+#include "src/core/lib/surface/channel.h"
 #include "test/core/end2end/cq_verifier.h"
 
 #define PING_NUM 5

test/core/surface/public_headers_must_be_c89.c

@@ -104,7 +104,6 @@ int main(int argc, char **argv) {
   printf("%lx", (unsigned long) grpc_channel_watch_connectivity_state);
   printf("%lx", (unsigned long) grpc_channel_support_connectivity_watcher);
   printf("%lx", (unsigned long) grpc_channel_create_call);
-  printf("%lx", (unsigned long) grpc_channel_ping);
   printf("%lx", (unsigned long) grpc_channel_register_call);
   printf("%lx", (unsigned long) grpc_channel_create_registered_call);
   printf("%lx", (unsigned long) grpc_call_arena_alloc);

test/core/transport/chttp2/too_many_pings_test.cc

@@ -49,6 +49,7 @@
 #include "src/core/lib/security/credentials/credentials.h"
 #include "src/core/lib/security/security_connector/alts/alts_security_connector.h"
 #include "src/core/lib/slice/slice_string_helpers.h"
+#include "src/core/lib/surface/channel.h"
 
 #include "test/core/util/memory_counters.h"
 #include "test/core/util/port.h"